Commit dfd608a1 authored by Kevin Yumang's avatar Kevin Yumang

SERV-2286 - refactor chart data maanger and series data objects

parent 1b3596b2
......@@ -28,42 +28,6 @@ class SeriesData
return $this->index;
}
private function getName() : string
{
return $this->name;
}
private function getCategoryValues() : array
{
return $this->categoryValues;
}
private function getType() : ?string
{
return $this->type;
}
private function getStackName() : ?string
{
return $this->stackName;
}
private function getShowPointValues() : ?bool
{
return $this->showPointValues;
}
private function getIsArea() : ?bool
{
return $this->isArea;
}
private function getMarkLine() : ?string
{
return $this->markLine;
}
public function setName(string $name) : SeriesData
{
$this->name = $name;
......@@ -121,9 +85,9 @@ class SeriesData
{
$data = [];
$data['name'] = $this->getName();
$data['data'] = $this->getCategoryValues();
$data['index'] = $this->getIndex();
$data['name'] = $this->name;
$data['data'] = $this->categoryValues;
$data['index'] = $this->index;
if(!is_null($this->type)) $data['type'] = $this->type;
if(!is_null($this->stackName)) $data['stacked'] = $this->stackName;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment